Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the SSL certificates in the tests #65

Closed
aecay opened this issue Jul 23, 2021 · 1 comment · Fixed by #71
Closed

Fix the SSL certificates in the tests #65

aecay opened this issue Jul 23, 2021 · 1 comment · Fixed by #71
Labels
good first issue Good for newcomers

Comments

@aecay
Copy link
Contributor

aecay commented Jul 23, 2021

Currently the tests need the setting GODEBUG=x509ignoreCN=0. That's because without that, on newer versions of go, the tests give the following error:

Post \"https://localhost:12984/access-token\": x509: certificate relies on legacy Common Name field, use SANs or temporarily enable Common Name matching with GODEBUG=x509ignoreCN=0

So ideally, the test suite needs to be updated so that it provisions certs that work with the expectations of the new versions of go (using SAN instead of CN, presumably). Then we can remove the GODEBUG workaround from the makefile.

@aecay aecay added the good first issue Good for newcomers label Jul 23, 2021
@aecay aecay mentioned this issue Jul 23, 2021
@ModelNaoe
Copy link

tough

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants