Skip to content
This repository has been archived by the owner on Jun 14, 2023. It is now read-only.

Support database query tracing using ocsql library #78

Closed
Saicasm opened this issue Nov 26, 2020 · 6 comments
Closed

Support database query tracing using ocsql library #78

Saicasm opened this issue Nov 26, 2020 · 6 comments
Labels
good first issue Good for newcomers plugin

Comments

@Saicasm
Copy link

Saicasm commented Nov 26, 2020

Is your feature request related to a problem? Please describe.
Currently go2sky doesn't automatically trace the database queries and its execution

Describe the solution you'd like
A wrapper which automatically traces the database query execution and produces the trace and links it to the parent span which can be a Http method/ any other

Additional context
ocsql warpper which provides tracing for tracing applications like zipkin and since skywalking uses different data format some code changes to the library will be required

@arugal
Copy link
Member

arugal commented Nov 26, 2020

Looks good, @Saicasm Do you plan to contribute this plugin?

@arugal arugal added this to the 1.0.0 milestone Nov 26, 2020
@arugal arugal added plugin good first issue Good for newcomers labels Nov 26, 2020
@Saicasm
Copy link
Author

Saicasm commented Nov 26, 2020

Looks good, @Saicasm Do you plan to contribute this plugin?

@arugal definitely would be contributing, are there any links or any examples in other languages for reference? .If I can have some context that would be great, Thank you

@arugal
Copy link
Member

arugal commented Nov 27, 2020

are there any links or any examples in other languages for reference?

About of database, as this comment says, you can also refer to our other plugin implementation, such as go-restful.

@Saicasm
Copy link
Author

Saicasm commented Nov 30, 2020

Hi @arugal , is there a reference where i can find the component ID for go plugins ?
Currently need the componentID for mysql ,sqlLite ,postgres.

Thank you

@arugal
Copy link
Member

arugal commented Nov 30, 2020

Hi @arugal , is there a reference where i can find the component ID for go plugins ?
Currently need the componentID for mysql ,sqlLite ,postgres.

Thank you

It need to be defined in component-library.yml, refer to PyMysql.

https://github.com/apache/skywalking/blob/master/oap-server/server-bootstrap/src/main/resources/component-libraries.yml#L47
https://github.com/apache/skywalking/blob/master/oap-server/server-bootstrap/src/main/resources/component-libraries.yml#L464
https://github.com/apache/skywalking/blob/master/oap-server/server-bootstrap/src/main/resources/component-libraries.yml#L548

@wu-sheng
Copy link
Member

If those are planned to be supported in golang, please submit a pull request to update the languages part.

@wu-sheng wu-sheng removed this from the 1.0.0 milestone Mar 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Good for newcomers plugin
Projects
None yet
Development

No branches or pull requests

3 participants