Tests!

[lucymhdavies]

I'm going to make every effort to make sure that all new stuff that gets added to this is tested.

I would very much like to go through and add tests for existing stuff too.

And set this up with Travis or Circle too.

[lucymhdavies]

Making a start on this with lucymhdavies@705795c

Got to start somewhere, right?

[edupo]

https://github.com/edupo/cali/blob/master/.travis.yml
It executes lot's of static analysis already...

[lucymhdavies]

Cool. Sounds like a good thing to have :)

I added a CircleCI config a while back, but I have no real preference for Circle over Travis, if you want to PR that in :)
(I've only added precisely two tests thus far anyway)

[edupo]

I don't mind either.
I open a PR #27 but we can port some of the test to cci but some of them may fail with the current code.

[lucymhdavies]

Merged your PR for Travis. :)

We can tweak it down the line, and decide on Circle vs Travis. But this gives us something to work with.

Once it's finished, we'll see what issues it finds, and raise issues to address those.

[lucymhdavies]

The command "go test -v -race ./..." exited with 2.
0.86s$ go vet ./...
# github.com/skybet/cali
./task.go:87: Errorf format %s reads arg #1, but call has only 0 args
./task.go:96: Errorf format %s reads arg #1, but call has only 0 args

The command "go vet ./..." exited with 2.
21.33s$ megacheck ./...
docker.go:205:20: os.Kill cannot be trapped (did you mean syscall.SIGTERM?) (SA1016)
docker.go:241:3: should check returned error before deferring hijack.Conn.Close() (SA5001)
docker.go:322:2: should use 'return <expr>' instead of 'if <expr> { return <bool> }; return <bool>' (S1008)
docker.go:48:2: field running is unused (U1000)

The command "megacheck ./..." exited with 1.
0.01s$ gocyclo -over 19 $GO_FILES

The command "golint -set_exit_status $(go list ./...)" exited with 1.

[lucymhdavies]

Working on fixes for the trivial issues in #35

[edupo]

The gocyclo was one of the hardest to fix. I just fixed it in my fork after a complete re-factor of what I understand as the Docker library cali uses to offer it's functionality.

So I suggest to disable that check until the docker part is cleaned.