Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/check empty password #663

Merged
merged 4 commits into from
Jan 27, 2021
Merged

Fix/check empty password #663

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
914c59e
add empty pw check to auppupdater factory
jdknives Jan 22, 2021
0cd5228
add condition to check for appupdate pw vpn-server
jdknives Jan 25, 2021
11d3260
refactor procArgs functions into appcommon
jdknives Jan 26, 2021
e6eb6dc
comment on functions to fix linter
jdknives Jan 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion pkg/app/appdisc/factory.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ func (f *Factory) AppUpdater(conf appcommon.ProcConfig) (Updater, bool) {
log := f.Log.WithField("appName", conf.AppName)

// Do not update in proxy discovery if passcode-protected.
if containsFlag(conf.ProcArgs, "passcode") {
if containsFlag(conf.ProcArgs, "passcode") && argVal(conf.ProcArgs, "passcode") != "" {
return &emptyUpdater{}, false
}

Expand Down Expand Up @@ -124,3 +124,13 @@ func argEqualsFlag(arg, flag string) bool {

return arg == flag
}

func argVal(args []string, flag string) string {
for idx, arg := range args {
if argEqualsFlag(arg, flag) {
return args[idx+1]
jdknives marked this conversation as resolved.
Show resolved Hide resolved
}
}

return ""
}