Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lint shows error for dimen resource id #190

Closed
dsuresh-ap opened this issue May 24, 2021 · 4 comments
Closed

Lint shows error for dimen resource id #190

dsuresh-ap opened this issue May 24, 2021 · 4 comments
Assignees
@skydoves
Labels
Released Released already on the latest version.

Comments

@dsuresh-ap
Copy link

Please complete the following information:

  • Library Version 1.3.4
  • Affected Device(s) Samsung Galaxy S9 Android 10

Describe the Bug:

Lint complains that instead of passing the resource id directly we should be calling resources.getDimension().

setMaxWidthResource(R.dimen.tutorial_tooltip_width)
image

Expected Behavior:

No lint error shows.
@skydoves skydoves self-assigned this May 25, 2021
@skydoves skydoves added the Release Next This feature will be released on next version label May 25, 2021
@skydoves
Copy link
Owner

Hi, thanks for reporting this issue :)
This issue is fixed in the snapshot 1.3.5-SNAPSHOT and will be included in the next stable release.
Thanks !

@dsuresh-ap
Copy link
Author

@skydoves Thanks!

@skydoves
Copy link
Owner

skydoves commented Jul 2, 2021

Released a new stable 1.3.5!

@skydoves skydoves added Released Released already on the latest version. and removed Release Next This feature will be released on next version labels Jul 2, 2021
@skydoves skydoves closed this as completed Jul 2, 2021
@dsuresh-ap
Copy link
Author

@skydoves Thanks it worked!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skydoves skydoves

Labels
Released Released already on the latest version.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dsuresh-ap @skydoves