Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] recognition of aliased mainactivities in manifest for debugging #1322

Closed
demonlol opened this issue Jan 2, 2022 · 3 comments
Closed
Labels
bug GUI Issues in jadx-gui module resources

Comments

@demonlol
Copy link
Contributor

demonlol commented Jan 2, 2022

An app I'm working with uses 2 mainactivity references, one being encapsulated by < activity-alias > instead of < activity > in its manifest. As a result, a messagebox will appear stating "Failed to decode AndroidManifest.xml" upon clicking "Launch App". There are no stacktraces or logs.

I've added detection for it since then, but figured I'd follow repo guidelines before submitting a PR.

@skylot
Copy link
Owner

skylot commented Jan 2, 2022

@demonlol this issue only appear while using debugger, right? Anyway, if possible, share sample APK.
And sure, PR with a fix will be great 👍

@skylot skylot added bug GUI Issues in jadx-gui module resources and removed new feature labels Jan 2, 2022
@demonlol
Copy link
Contributor Author

demonlol commented Jan 2, 2022

@skylot That's right. It's an error in the debugger. As you requested, I've attached a sample APK which will produce the same results. Let me know if my modifications are unsatisfactory #1323
sample.zip

skylot pushed a commit that referenced this issue Jan 2, 2022
…1322)(PR #1323)

* fix(dgb): support multiple main <action> and <activity-alias> tags in manifest
* Update jadx-gui/src/main/java/jadx/gui/device/debugger/DbgUtils.java
@skylot
Copy link
Owner

skylot commented Jan 2, 2022

Fixed in PR #1323

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug GUI Issues in jadx-gui module resources
Projects
None yet
Development

No branches or pull requests

2 participants