fix(dgb): support multiple main <action> and <activity-alias> tags #1323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skylot
requested changes
Jan 2, 2022
There was a problem hiding this comment.
@demonlol looks good.
But please apply code auto format, ie: gradle spotlessApply or check Code Formatting guide.
skylot
approved these changes
Jan 2, 2022
skylot
requested changes
Jan 2, 2022
Co-authored-by: skylot <118523+skylot@users.noreply.github.com>
Co-authored-by: skylot <118523+skylot@users.noreply.github.com>
skylot
approved these changes
Jan 2, 2022
|
@demonlol thank you for your work 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code works same prior to modification. The while loop ensures all instances of the tag are processed. I've added an additional lastIndexOf check for tags. The activity-alias tag gets the targetActivity attribute instead of the name.