Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.0.0版本闪退 #692

Closed
xmhwws opened this issue Jun 20, 2019 · 9 comments
Closed

1.0.0版本闪退 #692

xmhwws opened this issue Jun 20, 2019 · 9 comments

Comments

@xmhwws
Copy link

xmhwws commented Jun 20, 2019

使用不包含jre的版本,运行jadx-gui.bat闪退。
使用含有jre的版本,正常运行jadx-gui.bat。
我的java version是 "1.8.0_181",系统为windows10 x64 专业版。

@jpstotz
Copy link
Collaborator

jpstotz commented Jun 20, 2019

I am sorry please use English as language for writing issues and include a concrete description of your problem. From the online translated version of your issue I don't understand what your problem is.

@xmhwws
Copy link
Author

xmhwws commented Jun 20, 2019

I am sorry please use English as language for writing issues and include a concrete description of your problem. From the online translated version of your issue I don't understand what your problem is.

Because my English is not good, so I used Chinese previously, I am sorry.

Run jadx-gui.bat crash with a version that does not contain jre.
Use the jadx version with JRE to run jadx-gui.bat properly.

My java version is "1.8.0_181" and the system is Windows 10 x64 Professional Edition.

Can you understand what I said?

@jpstotz
Copy link
Collaborator

jpstotz commented Jun 20, 2019

Open a command-line (cmd.exe) an test the following commands:

  1. java -version --> output should include the version of your java runtime "1.8.0_181"
  2. where java.exe -> list of available java executables
  3. echo %JAVA_HOME%

Alternatively you can start jadx using jadx-gui.exe launcher. It searches automatically for an appropriate installed JRE.

@xmhwws
Copy link
Author

xmhwws commented Jun 20, 2019

Open a command-line (cmd.exe) an test the following commands:

  1. java -version --> output should include the version of your java runtime "1.8.0_181"
  2. where java.exe -> list of available java executables
  3. echo %JAVA_HOME%

Alternatively you can start jadx using jadx-gui.exe launcher. It searches automatically for an appropriate installed JRE.

Commands doesn't work,jadx-gui.bat still crash with a version that does not contain jre.
I use jadx-gui-1.0.0-with-jre-windows now,it can work properly.
I hope that jadx-1.0.0.zip can also work properly.
If there is no solution to this problem for the time being, ignore it.
I'm sorry to disturb you,thank you very much.

@jpstotz
Copy link
Collaborator

jpstotz commented Jun 20, 2019

The commands were not to fix the problem but to identify it. Please post the output.

@13-beta2
Copy link
Contributor

Most probably caused by introduced bug in jadx-gui.bat - JAVA_EXE quoted twice. To fix just replace

:findJavaFromJavaHome
set JAVA_HOME=%JAVA_HOME:"=%
set JAVA_EXE="%JAVA_HOME%/bin/javaw.exe"

if exist "%JAVA_EXE%" goto init

back with

:findJavaFromJavaHome
set JAVA_HOME=%JAVA_HOME:"=%
set JAVA_EXE=%JAVA_HOME%\bin\javaw.exe

if exist "%JAVA_EXE%" goto init

@PinkD
Copy link

PinkD commented Jun 21, 2019

Most probably caused by introduced bug in jadx-gui.bat - JAVA_EXE quoted twice. To fix just replace

:findJavaFromJavaHome
set JAVA_HOME=%JAVA_HOME:"=%
set JAVA_EXE="%JAVA_HOME%/bin/javaw.exe"

if exist "%JAVA_EXE%" goto init

back with

:findJavaFromJavaHome
set JAVA_HOME=%JAVA_HOME:"=%
set JAVA_EXE=%JAVA_HOME%\bin\javaw.exe

if exist "%JAVA_EXE%" goto init

I met the same problem, and I found the same solution

@jpstotz
Copy link
Collaborator

jpstotz commented Jun 21, 2019

@13-beta2 you are absolutely correct. I made a PR that includes your changes.

@jpstotz jpstotz closed this as completed Jun 21, 2019
@skylot
Copy link
Owner

skylot commented Jun 21, 2019

Thank you guys! I apply these changes to the release bundle 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants