[core] Miss of casts among primitive types

[bagipro]

Checks before report

• [+] check latest unstable build (maybe issue already fixed)
• [+] search existing issues by exception message
• [+] check Troubleshooting Q&A section on wiki

Describe error
Class com.paypal.android.p2pmobile.cfs.common.fragments.BaseShowCodeFragment

    private boolean isGoogleMapsInstalledAndEnabled() {
        int i = 0;
        try {
            return getActivity().getPackageManager().getApplicationInfo("com.google.android.apps.maps", i).enabled;
        } catch (android.content.pm.PackageManager.NameNotFoundException unused) {
            return i; // <<< should be boolean
        }
    }

Another example is in file com/paypal/android/sdk/contactless/reader/apdu/CApdu.java

    public CApdu(@NonNull Cla cla, @NonNull Ins ins, byte b, byte b2, @NonNull byte[] bArr) {
        this(cla, ins, b, b2, bArr, 0); // <<< 0 should be explicitly cast to byte, otherwise the referenced constructor is not found
    }

    public CApdu(@NonNull Cla cla, @NonNull Ins ins, byte b, byte b2, @NonNull byte[] bArr, byte b3) {
        this.f15523a = cla;
        this.f15524b = ins;
        this.f15525c = b;
        this.f15526d = b2;
        this.f15527e = bArr;
        this.f15528f = b3;
    }

APK: https://drive.google.com/file/d/1fCN9PXu8Zw4Kdnhgd0_qmzEvgWLfEU-9/view?usp=sharing

[bagipro]

And one more example boolean to int in file com/paypal/android/p2pmobile/p2p/common/adapters/OptionsAdapter.java

    public int getItemCount() {
        boolean z = this.mHasFooter;
        List<OPTION> list = this.mOptions;
        if (list != null) {
            return list.size() + z; // int + boolean
        }
        return z ? 1 : 0;
    }

[codezjx]

Similar issue in method overloading:

public class n {
    private int a = 0;
    private long b = 0;
    public void a(int i) {
        this.a = i;
    }
    public void a(long j) {
        this.b = j;
    }
    ...
}

And jadx decompile result was:

a = new n();
a.a(i);
a.a(-1);   // Actually result should be a.a(-1L), calling method with Long type parameter

This issue exist in version 1.0.0.

[bagipro]

@skylot
I see that the second issue is fixed now

    public CApdu(@NonNull Cla cla, @NonNull Ins ins, byte b, byte b2, @NonNull byte[] bArr) {
        this(cla, ins, b, b2, bArr, (byte) 0);
    }

    public CApdu(@NonNull Cla cla, @NonNull Ins ins, byte b, byte b2, @NonNull byte[] bArr, byte b3) {

but not the first one

    private boolean isGoogleMapsInstalledAndEnabled() {
        int i = 0;
        try {
            return getActivity().getPackageManager().getApplicationInfo("com.google.android.apps.maps", i).enabled;
        } catch (PackageManager.NameNotFoundException unused) {
            return i;
        }
    }

[skylot]

@sergey-wowwow I made a fix for the first one. Thanks for notice!

[bagipro]

@skylot
Thanks!