Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find Usage Error #742

Closed
xmhwws opened this issue Aug 25, 2019 · 5 comments
Closed

Find Usage Error #742

xmhwws opened this issue Aug 25, 2019 · 5 comments

Comments

@xmhwws
Copy link

xmhwws commented Aug 25, 2019

apk link:https://raw.githubusercontent.com/xmhwws/AApk/master/formatfa.reflectmaster_1.9.1.apk
method: formatfa.android.f.reflectmaster.b.a.static int a(String str)
image
Find Usage:
jadx
But it didn't find all of them.

Jeb:
jeb

image

Jeb is right, jadx also needs improvement.
In addition, this gradle project imports Android studio, which also has this problem.
It may be a bug?

@jpstotz
Copy link
Collaborator

jpstotz commented Aug 25, 2019

You are right, the usage reference is incomplete. Interesting enough the opposite direction works without problems.

Please note that the usage reference function of Jadx have to be used carefully as it (besides this bug) can always be incomplete. This can happen in case Jadx fails to decompile the method the method-to-be searched is called in.

@skylot
Copy link
Owner

skylot commented Aug 25, 2019

It is strange because I can't reproduce this issue, for me usage dialog shows all use places. Maybe it is a race condition :(
@xmhwws please try latest unstable build. Also, you can try to trigger full decompilation (using text search) before usage dialog.

@jpstotz
Copy link
Collaborator

jpstotz commented Aug 25, 2019

@skylot I used latest version from Git, jadx thread count set to 1 (using Java 11.0.4).

With background decompilation disabled if you first start the decompilation (e.g. by opening the text search window) the bug is present.

If you first open the class formatfa.android.f.reflectmaster.b.a and then trigger the decompilation the references are correct.

@skylot
Copy link
Owner

skylot commented Aug 25, 2019

@jpstotz thanks! I reproduce this and looks like this is a recent regression done in 068234f , so in release version this issue not exists.

@skylot
Copy link
Owner

skylot commented Aug 25, 2019

I made a fix, thanks for the help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants