Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quark-Engine integration #1135

Merged
merged 1 commit into from
Mar 12, 2021
Merged

Quark-Engine integration #1135

merged 1 commit into from
Mar 12, 2021

Conversation

pulorsok
Copy link
Contributor

#1119
Hi @skylot,
This is a quick PoC for quark integration, a few features have been done:

  1. add a quark button on Toolbar
  2. click to execute the Quark command
  3. output quark report as JSON
  4. show report on Tabbed panel

However, there is still some feature have not completed, such as code navigation by click on malware behaviour in the report. And also, Jadx doesn't have plugin framework yet, so I implemented quark integration into jadx-gui code base.

If you want to integrate quark by using plugin, we can help to implement some plugin feature for contribution.

Please let me know if you have any suggestion or question. :D

@lgtm-com
Copy link

lgtm-com bot commented Mar 12, 2021

This pull request introduces 5 alerts when merging 16309db into 9ef99a2 - view on LGTM.com

new alerts:

  • 2 for Unused format argument
  • 2 for Potential input resource leak
  • 1 for Building a command line with string concatenation

@skylot
Copy link
Owner

skylot commented Mar 12, 2021

@pulorsok looks great. Thanks!

some feature have not completed, such as code navigation by click on malware behaviour in the report.

I will try to complete this myself, if you have any other suggestions please add them to the original issue (#1119)

If you want to integrate quark by using plugin, we can help to implement some plugin feature for contribution.

Well, before that I need to understand what API jadx should expose for plugins, I will use your code as an example and try to extract it as a separate plugin module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants