Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download URL not found when multiple download links exist #67

Closed
ghost opened this issue Dec 6, 2021 · 7 comments
Closed

Download URL not found when multiple download links exist #67

ghost opened this issue Dec 6, 2021 · 7 comments

Comments

@ghost
Copy link

ghost commented Dec 6, 2021

  • magzdb version: 1.1.5
  • Python version: 3.9.7
  • Operating System: Ubuntu 21.10

Description

I'm trying to download an edition of scientific american from 1866. This issue is available and has two download links. The first link is dead/ goes to a page that says no resource. The second download link works, but magzdb doesn't see it.

http://magzdb.org/num/3694138

Format: pdf (12.62 megabytes / 13230323 b.) Download from [freelibrary.lib] Scan
author: no
Note: no
http://magzdb.org/file/262482/dl (The file is not available on this resource.)

Format: pdf (12.62 megabytes / 13230323 b.) Download from [file.magzdb.org] Scan
author: no
Note: no
http://magzdb.org/file/463968/dl
http://file.magzdb.org/ul/2490/1866/Scientific%20American%201866%20v015%20n16.pdf

magzdb -i 2490 -e 3694138 --downloader wget
2021-12-06 13:31:07.510 | INFO     | magzdb.magzdb:download:206 - Found 1 editions of Scientific_American
2021-12-06 13:31:07.510 | INFO     | magzdb.magzdb:download:211 - Downloading year 1866 id 3694138
2021-12-06 13:31:08.259 | ERROR    | magzdb.magzdb:download:226 - Download Url not found for http://magzdb.org/num/3694138/dl
@Coool
Copy link
Contributor

Coool commented Feb 8, 2022

Any updates on this issue? Are skyme5 want to resolve a issue?

@skyme5 skyme5 closed this as completed in 9a3f611 Feb 9, 2022
@skyme5
Copy link
Owner

skyme5 commented Feb 9, 2022

@Coool thanks for your interest. Can you test v1.1.6 if it resolves this issue?

@ghost
Copy link
Author

ghost commented Feb 9, 2022

@skyme5 Thanks for the update! It seems to work, but the output is no longer verbose so there are no longer any notifications or warnings to show download progress or if a file is already downloaded or is unavailable.

@skyme5
Copy link
Owner

skyme5 commented Feb 9, 2022

@Adam-0-Moore use --debug flag for verbose output.

@ghost
Copy link
Author

ghost commented Feb 9, 2022

@skyme5 --debug lists the download ids and url, but version 1.15 output a bunch of useful information like download status and error messages.

1.15:
Screenshot-9

1.16:
Screenshot 10

@skyme5
Copy link
Owner

skyme5 commented Feb 9, 2022

@Adam-0-Moore, now specifying --debug flag will show useful information as you mentioned, earlier this flag wasn't applied to external downloaders.

I haven't published latest commit but you can install from source using

pip install git+https://github.com/skyme5/magzdb.git

@Coool
Copy link
Contributor

Coool commented Feb 10, 2022

Hi!

skyme5, looks v1.1.6 OK. Only need use --debug to get some more verbose info.
P.S.
It took long time to fix issue ;). I started to update your code. I have suggestion to add second download mode. To specify magazine first issue and it goes through every next issue and downloads if exists.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants