Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About transition to federated plugin #10

Closed
Skyost opened this issue Mar 9, 2021 · 3 comments
Closed

About transition to federated plugin #10

Skyost opened this issue Mar 9, 2021 · 3 comments
Assignees

Comments

@Skyost
Copy link
Owner

Skyost commented Mar 9, 2021

This issue has been created to keep talking about #9. So, as I said in #9 (comment), I have done refactoring in cea115a and 5556a7b :

  • Moved all source files into the src directory.
  • Renamed BonsoirPlatformEvents into BonsoirAction (to avoid confusions with BonsoirEvent).
  • Merged MethodChannelBonsoir and BonsoirPlatformInterface because I thought it was not needed to have an abstraction for BonsoirPlatformInterface (but I'm not that sure about this one).

What do you think about it @Piero512 ?

@Skyost Skyost self-assigned this Mar 9, 2021
@Piero512
Copy link
Contributor

Piero512 commented Mar 9, 2021

This is very bad.
The merge of platform interface with the method channel is bad, other plug-ins don't necessarily need to use a method channel to implement a platform interface, so it should be separated. See
https://github.com/flutter/plugins/tree/master/packages/url_launcher/url_launcher_platform_interface/lib as an example.

@Piero512
Copy link
Contributor

Piero512 commented Mar 9, 2021

You might also check out my plugin extending the current previous platform. https://github.com/Piero512/bonsoir_linux_dbus

Skyost added a commit that referenced this issue Mar 10, 2021
@Skyost
Copy link
Owner Author

Skyost commented Mar 10, 2021

The merge of platform interface with the method channel is bad, other plug-ins don't necessarily need to use a method channel to implement a platform interface, so it should be separated.

I see. I reverted the change in 0b0475e.

@Skyost Skyost closed this as completed Apr 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants