Added confirmation prompt for sky storage delete, and --yes flag to skip it #2726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
@aseriesof-tubes Thanks for your contribution! Left some comments :)
Co-authored-by: Doyoung Kim <34902420+landscapepainter@users.noreply.github.com>
There was a problem hiding this comment.
Welcome to SkyPilot @aseriesof-tubes! I noticed some redundant messages and a bug when non-existent storage is specified, noted in comments below.
|
Thank you for the warm welcome @romilbhardwaj and @landscapepainter, your reviews are appreciated, and changes have been made! |
There was a problem hiding this comment.
Thanks for theq quick update @aseriesof-tubes ! Left some comments. This should be ready to merge after 👍
Co-authored-by: Doyoung Kim <34902420+landscapepainter@users.noreply.github.com>
|
Hi @landscapepainter @romilbhardwaj, the PR is ready for review again! Thank you for your patience :) |
landscapepainter
approved these changes
Nov 1, 2023
Co-authored-by: Doyoung Kim <34902420+landscapepainter@users.noreply.github.com>
This was referenced Nov 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for issue #2635
Added a feature for
sky storage deletewhere by default it shows a confirmation prompt before deleting, like insky downorsky stop. Like those commands, users can add a--yesflag to skip the confirmation prompt. Also changed some tests in test_smoke for TestStorageWithCredentials for the tests to automatically use the --yes flag.Tested (run the relevant ones):
bash format.shChanged some
check_outputcommands to include the--yesflag, so previously if it wascheck_output( ['sky', 'storage', 'delete', storage_name]), now it'scheck_output(['sky', 'storage', 'delete', storage_name, '--yes'])pytest tests/test_smoke.pypytest tests/test_smoke.py::TestStorageWithCredentialsbash tests/backward_comaptibility_tests.sh