[Storage] Storage tests cleanup and fixes #2774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romilbhardwaj
changed the title
landscapepainter
approved these changes
Nov 12, 2023
There was a problem hiding this comment.
@romilbhardwaj Thanks for the quick fix! Confirmed that the tests are fixed. LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-yintroduced by Added confirmation prompt for sky storage delete, and --yes flag to skip it #2726def test_kubernetes_storage_mounts_with_stopsince k8s does not support autostopping.test_xxx_storage_mounts. Superseded bytest_xxx_storage_mounts_with_stopTested:
pytest tests/test_smoke.py::test_aws_storage_mounts_with_stop --aws; pytest tests/test_smoke.py::test_gcp_storage_mounts_with_stop; pytest tests/test_smoke.py::test_kubernetes_storage_mounts --kubernetes; pytest tests/test_smoke.py::test_cloudflare_storage_mounts --cloudflare; pytest tests/test_smoke.py::test_ibm_storage_mounts --ibm