Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Setup] Not skipping conda init #2909

Merged
merged 2 commits into from
Dec 27, 2023
Merged

[Setup] Not skipping conda init #2909

merged 2 commits into from
Dec 27, 2023

Conversation

Michaelvll
Copy link
Collaborator

@Michaelvll Michaelvll commented Dec 27, 2023

Fixes #2908

This reverts changes in #2277, due to the update of GCP image has resolved the conda init issue in #2273

(Confirmed that the problem exists with the older image we used: sky launch -c test-old-image --cloud gcp --image-id skypilot:cpu-debian-10 'conda activate'. Though it takes longer to launch for older image, but it is not critical for user job.)

Tested (run the relevant ones):

  • Code formatting: bash format.sh
  • Any manual or new tests for this PR (please specify below)
    • sky launch -c test-aws-conda-init --cloud aws --cpus 2 'conda create -n test -y python=3.8; conda activate test; python --version'; ssh test-aws-conda-init; conda activate; python --version' (check provision.log that there is no error)
    • sky launch -c test-gcp-conda-init --cloud gcp --cpus 2 'conda create -n test -y python=3.8; conda activate test; python --version'; ssh test-gcp-conda-init; conda activate; python --version' (check provision.log that there is no error)
    • sky launch -c test-azure-conda-init --cloud gcp --cpus 2 'conda create -n test -y python=3.8; conda activate test; python --version'; ssh test-azure-conda-init; conda activate; python --version' (check provision.log that there is no error)
  • All smoke tests: pytest tests/test_smoke.py
  • Relevant individual smoke tests: pytest tests/test_smoke.py::test_fill_in_the_name
  • Backward compatibility tests: bash tests/backward_comaptibility_tests.sh

@Michaelvll Michaelvll merged commit bc0c99c into master Dec 27, 2023
19 checks passed
@Michaelvll Michaelvll deleted the fix-conda-init branch December 27, 2023 16:48
@Michaelvll Michaelvll mentioned this pull request Dec 28, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[AWS] AWS conda is not initialized causing conda activate not working
2 participants