New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Setup] Fix conda init #2912

Merged

Michaelvll merged 1 commit into master from fix-conda-not-found

Dec 28, 2023

Collaborator

Michaelvll commented Dec 28, 2023 •

edited

Revert part of the changes in #2909, as conda init requires conda to appear in the path.

Tested (run the relevant ones):

Code formatting: bash format.sh

Any manual or new tests for this PR (please specify below)

sky launch -c test-tpuvm test.yaml

resources: 
  accelerators: tpu-v2-8
  accelerator_args:
    tpu_vm: True

run: |
  echo "Hello World"

All smoke tests: pytest tests/test_smoke.py
Relevant individual smoke tests: pytest tests/test_smoke.py::test_fill_in_the_name
Backward compatibility tests: bash tests/backward_comaptibility_tests.sh


          Fix conda init

f2e1a70

Michaelvll requested a review from cblmemo

December 28, 2023 06:21

cblmemo approved these changes

View reviewed changes

Michaelvll merged commit 8f18a6d into master

19 checks passed

Michaelvll deleted the fix-conda-not-found branch

December 28, 2023 06:35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment