[Refactor] Remove local cloud implementation entirely #3037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
16 tasks
… remove-local-cloud
… remove-local-cloud
| in stderr): | ||
| error_msg = ( | ||
| f'The SkyPilot runtime on remote cluster {cluster_name!r} is ' | ||
| 'outdated. Please update the runtime with: ' |
There was a problem hiding this comment.
Thanks for adding this check!
When I run sky queue on a previously launched cluster, I get an AssertionError asking me to update the cluster. Is it possible to make it a little nicer, like we have for sky cancel?
There was a problem hiding this comment.
Good catch! Just fixed the output for sky queue : )
romilbhardwaj
approved these changes
Feb 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the local cloud as it is deprecated and replaced by our k8s support..
TODO:
Tested (run the relevant ones):
bash format.shpytest tests/test_smoke.pypytest tests/test_smoke.py::test_fill_in_the_namebash -i tests/backward_comaptibility_tests.sh 1(1means that relaunch is required for backward compat)