New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Core] Fix local cloud check #3186

Merged

cblmemo merged 2 commits into master from fix-local-cloud

Feb 19, 2024

Collaborator

cblmemo commented Feb 19, 2024

Fixes a bug introduced in #3037

Tested (run the relevant ones):

Code formatting: bash format.sh
Any manual or new tests for this PR (please specify below)
All smoke tests: pytest tests/test_smoke.py
Relevant individual smoke tests: pytest tests/test_smoke.py::test_fill_in_the_name
Backward compatibility tests: bash tests/backward_comaptibility_tests.sh

cblmemo added 2 commits

February 18, 2024 23:07

fix

210afe2

fix

acd2213

Michaelvll approved these changes

View reviewed changes

Collaborator

Michaelvll left a comment

Great catch @cblmemo! LGTM.

cblmemo merged commit 073e189 into master

19 checks passed

cblmemo deleted the fix-local-cloud branch

February 19, 2024 07:21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment