Skip to content
This repository has been archived by the owner on Oct 25, 2023. It is now read-only.

setup.py includes tests as a package #52

Closed
wykwit opened this issue Apr 4, 2021 · 1 comment · Fixed by #54
Closed

setup.py includes tests as a package #52

wykwit opened this issue Apr 4, 2021 · 1 comment · Fixed by #54

Comments

@wykwit
Copy link

wykwit commented Apr 4, 2021

Currently setup.py uses simple find_packages() which includes 'tests', 'tests.unit', 'tests.unit.plugins' and 'tests.unit.rules' in a list of packages.
This results in tests being installed under site-packages, outside of whispers folder.

$ ls lib/python3.9/site-packages   
tests  whispers  whispers-1.4.7-py3.9.egg-info

The solution would be to use find_packages() with additional exclude parameter, like so:

find_packages(exclude=['tests', 'tests.*'])
@adeptex
Copy link
Contributor

adeptex commented Apr 19, 2021

Hey @wykwit, interesting finding, thanks for raising! Let me have a look..

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants