Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace LambDynamicLights with Shimmer #36

Closed
Felix14-v2 opened this issue Sep 4, 2023 · 9 comments
Closed

Replace LambDynamicLights with Shimmer #36

Felix14-v2 opened this issue Sep 4, 2023 · 9 comments

Comments

@Felix14-v2
Copy link

Felix14-v2 commented Sep 4, 2023

Shimmer is a great project with a flexible configuration possibilities for users and devs, including colored dynamic lighting. And it already can work with Sodium 0.5 :)
Maybe give it a chance?

By the way, LambDynamicLights has been seen causing a huge performance drops on some devices, including mine. Here's an example:
https://discord.com/channels/977987490742935652/1125634282128408626/1125696662313111592

Demo from discord:
https://pomf2.lain.la/f/ca5t9oyd.mp4

@Gaming32
Copy link
Member

Gaming32 commented Sep 8, 2023

Shimmer doesn't work on Quilt because the mod is returning null from a method that is supposed to be not-null, which somehow works on Fabric, but doesn't on Quilt (as it shouldn't).

@MenacingPerson
Copy link

And the shimmer dev has some... weird... opinions on when they should add quilt support. According to them, quilt will be supported when quilt removes the WIP banner from their front page

@Gaming32
Copy link
Member

Gaming32 commented Sep 9, 2023

The weird thing is that the only place I found where it doesn't work is that they're returning null from a method that should never have null returned from it. It's sloppy code and it's breaking on Quilt because Quilt expects that code to be written properly.

@MenacingPerson
Copy link

Well, if they don't want to fix it then reporting it to the quilt devs will probably work

@Gaming32
Copy link
Member

Gaming32 commented Sep 9, 2023

Yeah, Quilt could probably handle that a bit better (like mimicking Fabric), but honestly it's just luck at this point that that doesn't crash on Fabric.

@MenacingPerson
Copy link

Shimmer also has a lot more stuff than LDL, that doesn't fit under OF compat. I wonder how laggy it is on low-end PCs.

@Felix14-v2
Copy link
Author

I wonder how laggy it is on low-end PCs.

Still better than LDL, which is broken on 1.20 (see attached video)

@Gaming32
Copy link
Member

At least LDL loads

@MenacingPerson
Copy link

Still better than LDL, which is broken on 1.20 (see attached video)

But that's a bug, surely. I meant that generally it seems to be doing a lot more, and it might not fit for Additive especially with coloured lights and stuff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

4 participants