Make sure to try to reconnect when request to dispatcher fails #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-matsui
changed the title
d-matsui
changed the title
d-matsui
requested review from
a team,
y-i and
riosu
and removed request for
a team
riosu
previously approved these changes
Jan 12, 2021
y-i
reviewed
Jan 12, 2021
d-matsui
changed the title
d-matsui
changed the title
y-i
suggested changes
Jan 18, 2021
src/peer/socket.js
Outdated
| * Return signaling server url. This attempts trying up to maxNumberOfAttempts times before giving up then throw error. | ||
| * @return {String} A string of signaling server url. | ||
| */ | ||
| async _getSignalingServerUrlWithRetry() { |
There was a problem hiding this comment.
_fetchSignalingServerUrlWithRetry seems to be better than _getSignalingServerUrlWithRetry because "get" does not seem to send request to server.
riosu
previously approved these changes
Jan 18, 2021
Co-authored-by: y-i <y-i@users.noreply.github.com>
riosu
approved these changes
Jan 18, 2021
This was referenced Jan 18, 2021
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check the type of change your PR introduces
Summary
There is a bug that a reconnect process to the signaling-server is stopped because the Peer's error event was fired when request to the dispatcher failed.
This PR allows to try to reconnect in such case.
Related Links (Issue, PR etc...) (Optional)
Check point