-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make sure to try to reconnect when request to dispatcher fails #297
Merged
Merged
Changes from 11 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
b55ae57
Make sure to try to reconnect when request to dispatcher fails
d-matsui 2de41a1
Add test code
d-matsui 677d8ae
Add _getSignalingServerUrlWithRetry method to make sure to retry
d-matsui 9ffa656
Add tests for socket._connectToNewServer()
d-matsui 5148d13
Move an variable to config file.
d-matsui b59560f
Apply lint fix
d-matsui 9add08d
Try changing servers up to 10 times.
d-matsui fa045d6
fix typo
d-matsui 1119f35
Add tests for _getSignalingServerUrlWithRetry
d-matsui 7276f55
Use assert.equal for checking error
d-matsui 9536a87
Undo changing config file
d-matsui 59acd19
Rename a private method
d-matsui 72d8b70
Update tests/peer/socket.js
d-matsui File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
_fetchSignalingServerUrlWithRetry
seems to be better than_getSignalingServerUrlWithRetry
because "get" does not seem to send request to server.