Serialisation of BIP32 misplaced address postition

[skywinder]

Look at the ending of testByBIP32keystoreSaveAndDeriva for details:

// This will fail. It wont fail if use scrypt from pod 'scrypt', '2.0', not from CryptoSwift
        XCTAssert(keystore?.addresses![0] == recreatedStore?.addresses![1])
        XCTAssert(keystore?.addresses![1] == recreatedStore?.addresses![0])

Adressed switched their position after serialisation (by native JSONEncoder().encode(params)
works fine when you run single test and mix them, when run. test suite.

[podkovyrin]

I'm wondering why the assertion is to have [0] == [1] and [1] == [0]?

[skywinder]

@podkovyrin that's why I create this issue. Can't understand why they swaped.

[podkovyrin]

I see. I came up with the following workaround-like solution so far: 1inch@13088a0
If you think that's acceptable I can make a PR.

[skywinder]

@podkovyrin Awesome!
I will also send you bounty un reward for fixing this! 👍

ps.
I see that you have another good fixes for library: I like that you extract "magic constants" from the code. I would be happy to merge PR too 👍
Just want to ask to split this to separate PR.

[gitcoinbot]

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

---

This issue now has a funding of 0.0512 ETH (17.32 USD @ $338.24/ETH) attached to it.

• If you would like to work on this issue you can 'start work' on the Gitcoin Issue Details page.
• Want to chip in? Add your own contribution here.
• Questions? Checkout Gitcoin Help or the Gitcoin Chat
• $737,521.05 more funded OSS Work available on the Gitcoin Issue Explorer

[gitcoinbot]

@podkovyrin Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

• reminder (3 days)
• escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[gitcoinbot]

@podkovyrin Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

• reminder (3 days)
• escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[podkovyrin]

@gitcoinbot yes, bot. I'm working

[skywinder]

@podkovyrin No worries and no rush. Code&chill👍

[gitcoinbot]

@podkovyrin Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

• reminder (3 days)
• escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[gitcoinbot]

@podkovyrin Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

• reminder (3 days)
• escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[gitcoinbot]

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

---

Work has been started.

These users each claimed they can complete the work by 3 days from now.
Please review their action plans below:

1) podkovyrin has been approved to start work.

Going to do git cherry-pick. Why I need to type 30 chars here???

Learn more on the Gitcoin Issue Details page.

[gitcoinbot]

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

---

@podkovyrin due to inactivity, we have escalated this issue to Gitcoin's moderation team. Let us know if you believe this has been done in error!

• reminder (3 days)
• escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[gitcoinbot]

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

---

@podkovyrin due to inactivity, we have escalated this issue to Gitcoin's moderation team. Let us know if you believe this has been done in error!

• reminder (3 days)
• escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[skywinder]

@podkovyrin thank you for your outstanding work! Since you already made PR, Please submit for this bounty. I would be happy to reward you!
Happy New Year! 🎉

[gitcoinbot]

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

---

Work for 0.1 ETH (74.25 USD @ $754.31/ETH) has been submitted by:

---

• Learn more on the Gitcoin Issue Details page
• Want to chip in? Add your own contribution here.
• Questions? Checkout Gitcoin Help or the Gitcoin Chat
• $999,695.82 more funded OSS Work available on the Gitcoin Issue Explorer