Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#248 #250

Merged
merged 1 commit into from
Mar 19, 2020
Merged

#248 #250

merged 1 commit into from
Mar 19, 2020

Conversation

hakumai-iida
Copy link
Contributor

@hakumai-iida hakumai-iida commented Mar 18, 2020 •
edited by skywinder

Fixed below.

  • EventFiltering does not work, if the count of "parameterFilters" is 1.
  • Also does not work, if events have jumping indexed parameters.

This fix #248

@hakumai-iida
#248
5fcf236 
Fixed below.
- EventFiltering does not work, if the count of "parameterFilters" is 1.
- Also does not work, if events have jumping indexed parameters.
@skywinder skywinder requested a review from BaldyAsh March 19, 2020 07:31
@skywinder
Copy link
Collaborator

Thanks! Please, apply yourself to https://gitcoin.co/issue/matter-labs/web3swift/248/4132

cc @BaldyAsh could you please review this fix?

@BaldyAsh
Copy link
Collaborator

@hakumai-iida thanks!

BaldyAsh
BaldyAsh approved these changes Mar 19, 2020
View reviewed changes
Copy link
Collaborator

@BaldyAsh BaldyAsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now, it's ok. Later I'll refactor everything anyway

@BaldyAsh BaldyAsh changed the base branch from master to develop March 19, 2020 10:05
@BaldyAsh BaldyAsh merged commit 156d7b9 into web3swift-team:develop Mar 19, 2020
@hakumai-iida
Copy link
Contributor Author

@skywinder
@BaldyAsh

Thank you very much for the merging.
I have deleted my temporary fork.

It was good to be helpful.

Best regards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BaldyAsh BaldyAsh BaldyAsh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Event filters by Param not working
3 participants
@hakumai-iida @skywinder @BaldyAsh