Unfinished Toggl Entries Trigger an Error

[necopinus]

If rake toggl:update RAILS_ENV=production is run when there are unfinished time entries in Toggl, it fails with the message "Validation failed: Hours is invalid".

Steps to reproduce:

1. Start a time entry in Toggl with a valid ticket number (#1234, etc.).
2. Run rake toggl:update RAILS_ENV=production; this will fail with "Validation failed: Hours is invalid".
3. Stop the timer in Toggl.
4. Rerun rake toggl:update RAILS_ENV=production; everything should now work fine.

[SkyWriter]

This is somewhat intended behavior. It doesn't register the entry until it's finished. Once it's finished, it puts it into Redmine and never touches it again.

Anyway I'm open to any suggestions on how to make it better, so if you have any reasonable proposals, I'm all into them. What do you think the correct behavior should be?

[necopinus]

That makes sense.

I think my suggestion then would be to generate a warning to stdout on this case, rather than throwing out a message on stderr. The case of an unclosed time entry really isn't an error, and it makes the plugin rather noisy in even a modestly active environment (5 users, in our case).

I don't mind throwing away stdout on a cron job but it's generally useful to get the output of stderr if something fails, so just running rake toggl:update RAILS_ENV=production &> /dev/null isn't a great solution.

[SkyWriter]

I've fixed this with the last commits. Would you be so kind to check it?

[necopinus]

Looks good on my end. Thanks!

[SkyWriter]

My pleasure!