Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selected text is removed when clicking toolbar menu button (color or background) #2637

Closed
ddtobiasz opened this issue Jun 4, 2019 · 3 comments

Comments

@ddtobiasz
Copy link

ddtobiasz commented Jun 4, 2019

Steps for Reproduction

  1. Visit https://quilljs.com/playground/#class-vs-inline-style
  2. Select the entire top line of text (with mouse)
  3. Change the color or background color
  4. Try repeating this again and again (select an entire line and try to change color or background color)
  5. Sometimes you have to repeat the "select text & change color steps" multiple times for it to actually work

Example of this occurring:
58569195-a4a06a80-8203-11e9-898f-e60f8b4f7a5b

Platforms:
Chrome version 74.0.3729.169 (Official Build) (64-bit)
Occurring on both Mac and Windows OS

Version:
v1.3.6

@ddtobiasz
Copy link
Author

This seems related to #645, however where 645 says "The actual functionality is fine. The previously selected text gets the new background color, it's only the display of the selection that gets removed.", that is no longer the case. In my testing there are scenarios where the color change doesn't work.

@TejasAghade
Copy link

Still facing same issue, selection is getting removed if opened any drop-down from toolbar, but the style is getting applied to selection.

@quill-bot
Copy link

Quill 2.0 has been released (announcement post) with many changes and fixes. If this is still an issue please create a new issue after reviewing our updated Contributing guide 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants