Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw an error if both socketMode: boolean and receiver: Receiver arguments in App constructor #1068

Closed
4 of 10 tasks
seratch opened this issue Aug 18, 2021 · 0 comments · Fixed by #1077
Closed
4 of 10 tasks

Throw an error if both socketMode: boolean and receiver: Receiver arguments in App constructor #1068

seratch opened this issue Aug 18, 2021 · 0 comments · Fixed by #1077
Assignees
@seratch
Labels
enhancement M-T: A feature request for new functionality
Milestone
3.7.0

Comments

@seratch
Copy link
Member

seratch commented Aug 18, 2021

Description

As described in #834, currently the App constructor quietly ignores the receiver: Receiver argument when socketMode: boolean as true is given. As this behavior is confusing, we can improve it to throw an exception with a clear error message.

What type of issue is this? (place an x in one of the [ ])

  • bug
  • enhancement (feature request)
  • question
  • documentation related
  • example code related
  • testing related
  • discussion

Requirements (place an x in each of the [ ])

  • I've read and understood the Contributing guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've searched for any related issues and avoided creating a duplicate issue.
@seratch seratch added the enhancement M-T: A feature request for new functionality label Aug 18, 2021
@seratch seratch added this to the 3.6.0 milestone Aug 18, 2021
@seratch seratch mentioned this issue Aug 18, 2021
Closed
10 tasks
@srajiang srajiang modified the milestones: 3.6.0, 3.7.0 Aug 19, 2021
seratch added a commit to seratch/bolt-js that referenced this issue Aug 24, 2021
@seratch
Fix slackapi#1068 Throw an error if both socketMode: boolean and rece…
f6c26af 
…iver: Receiver arguments in App constructor
@seratch seratch mentioned this issue Aug 24, 2021
Merged
2 tasks
seratch added a commit that referenced this issue Aug 25, 2021
@seratch
Fix #1068 Throw an error if both socketMode: boolean and receiver: Re…
cc6590f 
…ceiver arguments in App constructor (#1077)

* Fix #1068 Throw an error if both socketMode: boolean and receiver: Receiver arguments in App constructor

* Update src/App.ts
@seratch seratch self-assigned this Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@seratch seratch

Labels
enhancement M-T: A feature request for new functionality
Projects
None yet
Milestone
3.7.0
2 participants
@seratch @srajiang