Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1068 Throw an error if both socketMode: boolean and receiver: Receiver arguments in App constructor #1077

Merged
merged 4 commits into from Aug 25, 2021

Conversation

seratch
Copy link
Member

@seratch seratch commented Aug 24, 2021

Summary

This pull request fixes #1068 . I'm feeling that the error message can be improved. Suggestions would be appreciated!

Requirements (place an x in each [ ])

…iver: Receiver arguments in App constructor
@seratch seratch added the enhancement M-T: A feature request for new functionality label Aug 24, 2021
@seratch seratch added this to the 3.7.0 milestone Aug 24, 2021
src/App.ts Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Aug 24, 2021

Codecov Report

Merging #1077 (3d846f4) into main (02d601d) will increase coverage by 0.13%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1077      +/-   ##
==========================================
+ Coverage   68.73%   68.87%   +0.13%     
==========================================
  Files          13       13              
  Lines        1206     1208       +2     
  Branches      355      356       +1     
==========================================
+ Hits          829      832       +3     
  Misses        304      304              
+ Partials       73       72       -1     
Impacted Files Coverage Δ
src/App.ts 83.19% <100.00%> (+0.37%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02d601d...3d846f4. Read the comment docs.

src/App.ts Outdated Show resolved Hide resolved
src/App.ts Outdated Show resolved Hide resolved
@seratch
Copy link
Member Author

seratch commented Aug 24, 2021

I think this one is ready for merge but just in case, I'll wait for others' comments until tomorrow.

Copy link
Member

@srajiang srajiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@seratch seratch merged commit cc6590f into slackapi:main Aug 25, 2021
@seratch seratch deleted the issue-1068-socket-mode-custom-receiver branch August 25, 2021 22:40
@seratch seratch self-assigned this Aug 26, 2021
@M1kep M1kep mentioned this pull request Oct 28, 2021
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement M-T: A feature request for new functionality semver:patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Throw an error if both socketMode: boolean and receiver: Receiver arguments in App constructor
5 participants