Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1819 Add metadata to response_url params #1821

Merged
merged 1 commit into from
May 1, 2023

Conversation

seratch
Copy link
Member

@seratch seratch commented May 1, 2023

Summary

This pull request resolves #1819

Requirements (place an x in each [ ])

@seratch seratch added bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented TypeScript-specific labels May 1, 2023
@seratch seratch added this to the 3.13.2 milestone May 1, 2023
@seratch seratch self-assigned this May 1, 2023
@codecov
Copy link

codecov bot commented May 1, 2023

Codecov Report

Merging #1821 (1ad3f69) into main (261030d) will not change coverage.
The diff coverage is n/a.

❗ Current head 1ad3f69 differs from pull request most recent head 2c0f53c. Consider uploading reports for the commit 2c0f53c to get more accurate results

@@           Coverage Diff           @@
##             main    #1821   +/-   ##
=======================================
  Coverage   82.15%   82.15%           
=======================================
  Files          18       18           
  Lines        1519     1519           
  Branches      435      435           
=======================================
  Hits         1248     1248           
  Misses        175      175           
  Partials       96       96           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@mwbrooks mwbrooks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@seratch seratch merged commit 9e0b8ac into slackapi:main May 1, 2023
4 checks passed
@seratch seratch deleted the issue-1819-metadata-respond branch May 1, 2023 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented TypeScript-specific
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add metadata to response_url params
2 participants