Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metadata to response_url params #1819

Closed
ducminh-phan opened this issue Apr 29, 2023 · 5 comments · Fixed by #1821
Closed

Add metadata to response_url params #1819

ducminh-phan opened this issue Apr 29, 2023 · 5 comments · Fixed by #1821
Labels
bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented TypeScript-specific
Milestone

Comments

@ducminh-phan
Copy link

Reproducible in:

The Slack SDK version

@slack/bolt@3.13.0

Node.js runtime version

v16.14.0

OS info

N/A

Steps to reproduce:

type ChatPostMessageArgumentsKnownKeys =
| 'token'
| 'channel'
| 'text'
| 'as_user'
| 'attachments'
| 'blocks'
| 'icon_emoji'
| 'icon_url'
| 'link_names'
| 'mrkdwn'
| 'parse'
| 'reply_broadcast'
| 'thread_ts'
| 'unfurl_links'
| 'unfurl_media'
| 'username';

Expected result:

There should be the key metadata as it seems to be supported. I have tested and metadata is sent successfully.

Actual result:

There is no key metadata

image

@seratch seratch added bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented and removed untriaged labels May 1, 2023
@seratch seratch added this to the 3.13.2 milestone May 1, 2023
@seratch seratch changed the title (Set a clear title describing the issue) Add metadata to response_url params May 1, 2023
@seratch
Copy link
Member

seratch commented May 1, 2023

Hi @ducminh-phan, thanks for taking the time to report this issue! You're right that metadata parameter must be allowed for response_url requests. We will resolve this issue in the next release.

@Joebayld
Copy link

I'm having an issue since this fix. It appears it's now requiring metadata to be in the response when it should be optional.
image

@gfpacheco
Copy link

@seratch any updates on this? I'm facing the same issue as @Joebayld

@seratch
Copy link
Member

seratch commented Sep 7, 2023

@gfpacheco @Joebayld Could you help me figure out how to reproduce the issue you've observed?

I've never experienced the type errors in TS:

One possibility is that some of your @slack/ prefixed packages could be quite old and that might cause unexpected type resolution (if that's that case, the minimum requried versions of underlying packages need to be improved). Please check the dependencies and try the latest versions for all of them.

@gfpacheco
Copy link

gfpacheco commented Sep 7, 2023

@seratch you're right! After deleting node_modules and yarn.lock, and running yarn install again the error dissapeared

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented TypeScript-specific
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants