Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable to use installation_store_bot_only flag not only as the top-level arg #177

Closed
seratch opened this issue Dec 9, 2020 · 0 comments · Fixed by #178
Closed

Enable to use installation_store_bot_only flag not only as the top-level arg #177

seratch opened this issue Dec 9, 2020 · 0 comments · Fixed by #178
Assignees
Labels
area:async area:sync bug Something isn't working
Milestone

Comments

@seratch
Copy link
Member

seratch commented Dec 9, 2020

With version 1.1.2, the newly added flag installation_store_bot_only works only when being set to the top-level field. The constructor's initialization needs to be smarter to check if the flag is set in the OAuthFlow / OAuthSettings level.

Reproducible in:

pip freeze | grep slack
python --version
sw_vers && uname -v # or `ver`

The slack_bolt version

version 1.1.2

Python runtime version

any

OS info

any

Steps to reproduce:

App(installation_store_bot_only=True)
App(oauth_flow=OAuthFlow(settings=OAuthSettings(installation_store_bot_only=True))
App(oauth_settings=OAuthSettings(installation_store_bot_only=True))

Expected result:

All the three examples should work in the same way.

Actual result:

Only the first one works as expected.

Requirements

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:async area:sync bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant