Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #177 by updating App/AsyncApp bot_only flag initialization #178

Merged
merged 1 commit into from
Dec 11, 2020

Conversation

seratch
Copy link
Member

@seratch seratch commented Dec 11, 2020

This pull request fixes #177 - see the issue for details.

Category (place an x in each of the [ ])

  • slack_bolt.App and/or its core components
  • slack_bolt.async_app.AsyncApp and/or its core components
  • Adapters in slack_bolt.adapter
  • Document pages under /docs
  • Others

Requirements (place an x in each [ ])

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run ./scripts/install_all_and_run_tests.sh after making the changes.

@seratch seratch added bug Something isn't working area:async area:sync labels Dec 11, 2020
@seratch seratch added this to the 1.1.3 milestone Dec 11, 2020
@seratch seratch self-assigned this Dec 11, 2020
@codecov-io
Copy link

codecov-io commented Dec 11, 2020

Codecov Report

Merging #178 (e23f340) into main (890cf3f) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #178      +/-   ##
==========================================
+ Coverage   91.72%   91.76%   +0.04%     
==========================================
  Files         149      149              
  Lines        4434     4446      +12     
==========================================
+ Hits         4067     4080      +13     
+ Misses        367      366       -1     
Impacted Files Coverage Δ
slack_bolt/app/app.py 86.89% <100.00%> (+0.17%) ⬆️
slack_bolt/app/async_app.py 94.83% <100.00%> (+0.07%) ⬆️
slack_bolt/logger/messages.py 88.37% <100.00%> (+0.56%) ⬆️
...e/authorization/async_multi_teams_authorization.py 91.17% <0.00%> (+2.94%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 890cf3f...e23f340. Read the comment docs.

@seratch seratch merged commit d82a7d9 into slackapi:main Dec 11, 2020
@seratch seratch deleted the issue-177-bot-only branch December 11, 2020 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:async area:sync bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable to use installation_store_bot_only flag not only as the top-level arg
2 participants