Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow locally-running functions to access files.slack.com #66

Merged
merged 2 commits into from
Aug 1, 2024

Conversation

filmaj
Copy link
Contributor

@filmaj filmaj commented Jul 30, 2024

This should address slackapi/deno-slack-sdk#347, at least for locally running functions.

@filmaj filmaj added bug Something isn't working semver:patch requires a patch version number bump labels Jul 30, 2024
@filmaj filmaj self-assigned this Jul 30, 2024
@filmaj filmaj requested a review from a team as a code owner July 30, 2024 18:27
Copy link

codecov bot commented Jul 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.87%. Comparing base (56f53ef) to head (fef915a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #66      +/-   ##
==========================================
+ Coverage   94.14%   94.87%   +0.73%     
==========================================
  Files          14       14              
  Lines         461      527      +66     
  Branches       88       88              
==========================================
+ Hits          434      500      +66     
  Misses         27       27              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@WilliamBergamin WilliamBergamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@filmaj filmaj merged commit bd1bc36 into main Aug 1, 2024
6 checks passed
@filmaj filmaj deleted the slack-files-access branch August 1, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working semver:patch requires a patch version number bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants