Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allows users to configure the TTL of conversation info data #560

Merged
merged 1 commit into from
Apr 29, 2019

Conversation

aoberoi
Copy link
Contributor

@aoberoi aoberoi commented Apr 29, 2019

Summary

This PR adds configurability to the time Hubot will consider the data returned from conversations.info "fresh", without fetching it once again. This allows users to address concerns such as the on raised in #554.

Requirements (place an x in each [ ])

@codecov
Copy link

codecov bot commented Apr 29, 2019

Codecov Report

Merging #560 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #560      +/-   ##
==========================================
+ Coverage   86.29%   86.32%   +0.03%     
==========================================
  Files           6        6              
  Lines         372      373       +1     
  Branches       83       83              
==========================================
+ Hits          321      322       +1     
  Misses         29       29              
  Partials       22       22
Impacted Files Coverage Δ
src/client.coffee 95.19% <100%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3acc28...a5d67e2. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Apr 29, 2019

Codecov Report

Merging #560 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #560      +/-   ##
==========================================
+ Coverage   86.29%   86.32%   +0.03%     
==========================================
  Files           6        6              
  Lines         372      373       +1     
  Branches       83       83              
==========================================
+ Hits          321      322       +1     
  Misses         29       29              
  Partials       22       22
Impacted Files Coverage Δ
src/client.coffee 95.19% <100%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3acc28...a5d67e2. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants