Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade p-queue (no changes) #1097

Merged
merged 1 commit into from
Sep 23, 2020

Conversation

FauxFaux
Copy link
Contributor

Summary

p-queue now provides its own types, and @types/p-queue throws a deprecation warning,
so remove it. (I only care about the deprecation warning.)

Requirements (place an x in each [ ])

p-queue provides its own types, and @types/p-queue throws a deprecation warning,
so remove it.
@gitwave gitwave bot added the untriaged label Sep 23, 2020
@CLAassistant
Copy link

CLAassistant commented Sep 23, 2020

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Sep 23, 2020

Codecov Report

Merging #1097 into main will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1097   +/-   ##
=======================================
  Coverage   94.35%   94.35%           
=======================================
  Files          12       12           
  Lines         797      797           
  Branches      177      177           
=======================================
  Hits          752      752           
  Misses         15       15           
  Partials       30       30           
Flag Coverage Δ
#eventsapi 90.74% <ø> (ø)
#interactivemessages 94.83% <ø> (ø)
#webapi 95.59% <ø> (ø)
#webhook 87.50% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cebb85e...2d1e09d. Read the comment docs.

@FauxFaux FauxFaux marked this pull request as ready for review September 23, 2020 08:14
Copy link
Member

@stevengill stevengill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I reviewed the breaking changes on pqueue since the previous major we used. Nothing breaks on our end to upgrade.

Thanks for sending this in!

@stevengill stevengill merged commit 6ff0bf8 into slackapi:main Sep 23, 2020
@stevengill stevengill self-assigned this Sep 23, 2020
@aoberoi
Copy link
Contributor

aoberoi commented Sep 23, 2020

@stevengill how do we verify changes like v6.5.0 don't break anything? specifically, that release updates TypeScript to v3.9, which is above our projects' minimum TypeScript version of v3.3.

i recall that in the past situations where dependencies (especially those that bundle their own type definitions instead of retrieving them from DT) start to use new TypeScript syntax, that effectively bumps our project's minimum TypeScript version, too. but i'm not sure if that was all cases, or only in cases where some part of our project's API was dependent on a type from the dependencies API.

i think, before the changes in #831 for the sdk-integration-tests, we actually had CI verify the compatibility with our oldest supported TypeScript version. i'm not sure the refactored version provides that verification anymore.

@stevengill stevengill added semver:patch pkg:web-api applies to `@slack/web-api` and removed untriaged labels Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:web-api applies to `@slack/web-api` semver:patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants