Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metadata support to Incoming Webhooks #1362

Merged
merged 1 commit into from
May 1, 2023

Conversation

seratch
Copy link
Member

@seratch seratch commented May 1, 2023

Summary

As pointed out at slackapi/bolt-js#1819, metadata argument must be supported when posting a message using response_url and incoming webhooks

Category (place an x in each of the [ ])

  • slack_sdk.web.WebClient (sync/async) (Web API client)
  • slack_sdk.webhook.WebhookClient (sync/async) (Incoming Webhook, response_url sender)
  • slack_sdk.socket_mode (Socket Mode client)
  • slack_sdk.signature (Request Signature Verifier)
  • slack_sdk.oauth (OAuth Flow Utilities)
  • slack_sdk.models (UI component builders)
  • slack_sdk.scim (SCIM API client)
  • slack_sdk.audit_logs (Audit Logs API client)
  • slack_sdk.rtm_v2 (RTM client)
  • /docs-src (Documents, have you run ./scripts/docs.sh?)
  • /docs-src-v2 (Documents, have you run ./scripts/docs-v2.sh?)
  • /tutorial (PythOnBoardingBot tutorial)
  • tests/integration_tests (Automated tests for this library)

Requirements (place an x in each [ ])

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.sh after making the changes.

@seratch seratch added bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented web-client Version: 3x labels May 1, 2023
@seratch seratch added this to the 3.22.0 milestone May 1, 2023
@seratch seratch self-assigned this May 1, 2023
@codecov
Copy link

codecov bot commented May 1, 2023

Codecov Report

Merging #1362 (c64f65f) into main (8815d21) will decrease coverage by 0.04%.
The diff coverage is n/a.

❗ Current head c64f65f differs from pull request most recent head a6d1a93. Consider uploading reports for the commit a6d1a93 to get more accurate results

@@            Coverage Diff             @@
##             main    #1362      +/-   ##
==========================================
- Coverage   85.58%   85.54%   -0.04%     
==========================================
  Files         111      111              
  Lines       11557    11557              
==========================================
- Hits         9891     9887       -4     
- Misses       1666     1670       +4     
Impacted Files Coverage Δ
slack_sdk/webhook/async_client.py 92.23% <ø> (ø)
slack_sdk/webhook/client.py 93.91% <ø> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@seratch seratch merged commit bdb5551 into slackapi:main May 1, 2023
7 checks passed
@seratch seratch deleted the metadata-to-webhooks branch May 1, 2023 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented Version: 3x web-client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants