Update run_*.sh scripts #1443
Merged
Update run_*.sh scripts #1443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1443 +/- ##
=======================================
Coverage 85.59% 85.60%
=======================================
Files 111 111
Lines 12128 12128
=======================================
+ Hits 10381 10382 +1
+ Misses 1747 1746 -1 ☔ View full report in Codecov by Sentry. |
The Maintainers Guide says that no formatter nor code analyzer is involved when you run unit tests, so I suppose black was added by mistake and should be removed. Also, using set -e allows you to avoid chaining of commands. These changes: * remove black from run_*_tests.sh scripts * add set -e to unchain commands in scripts * simplify handling of a test target
Jamim
force-pushed
the
feature/update-run-scripts
branch
from
1f92cbe
to
c793768
Compare
seratch
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Hello,
The Maintainers Guide says that no formatter nor code analyzer is involved when you run unit tests, so I suppose
blackwas added by mistake and should be removed.Also, using set -e allows you to avoid chaining of commands.
I'd like to suggest changes that:
blackfromrun_*_tests.shscriptsset -eto unchain commands in scriptsBest regards!
Category (place an
xin each of the[ ])/scripts/docs-src(Documents, have you run./scripts/docs.sh?)/docs-src-v2(Documents, have you run./scripts/docs-v2.sh?)/tutorial(PythOnBoardingBot tutorial)tests/integration_tests(Automated tests for this library)Requirements (place an
xin each[ ])python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.shafter making the changes.