-
Notifications
You must be signed in to change notification settings - Fork 837
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
The Maintainers Guide says that no formatter nor code analyzer will be involved when you run unit tests, so I suppose black was added by mistake and should be removed. Also, using set -e allows you to avoid chaining of commands. These changes: * remove black from run_*_tests.sh scripts * add set -e to unchain commands in scripts
- Loading branch information
Showing
3 changed files
with
32 additions
and
28 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,17 @@ | ||
#!/bin/bash | ||
# ./scripts/run_validation.sh | ||
|
||
set -e | ||
|
||
script_dir=`dirname $0` | ||
cd ${script_dir}/.. | ||
pip install -U pip && \ | ||
pip install -r requirements/testing.txt && \ | ||
pip install -r requirements/optional.txt && \ | ||
black slack_sdk/ slack/ tests/ integration_tests/ && \ | ||
python setup.py codegen && \ | ||
python setup.py validate | ||
pip install -U pip | ||
pip install -r requirements/testing.txt \ | ||
-r requirements/optional.txt | ||
|
||
black --check tests/ integration_tests/ | ||
# TODO: resolve linting errors for tests | ||
# flake8 tests/ integration_tests/ | ||
|
||
python setup.py codegen | ||
python setup.py validate |