Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SignatureVerifier for request verification #686

Merged
merged 2 commits into from May 15, 2020

Conversation

seratch
Copy link
Member

@seratch seratch commented May 14, 2020

Summary

This pull request adds the official implementation of Slack request verification. We have been having this logic as a static method in BaseClient but it's not the right place to have it.

When we release version 2.6.0 with this change, I'll update this part of the document. https://slack.dev/python-slackclient/basic_usage.html#opening-a-modal

Requirements (place an x in each [ ])

@seratch seratch added Version: 2x enhancement M-T: A feature request for new functionality v2.6 in-progress labels May 14, 2020
@seratch seratch added this to the 2.6.0 milestone May 14, 2020
@seratch seratch self-assigned this May 14, 2020
@codecov
Copy link

codecov bot commented May 14, 2020

Codecov Report

Merging #686 into master will increase coverage by 0.53%.
The diff coverage is 87.17%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #686      +/-   ##
==========================================
+ Coverage   84.76%   85.29%   +0.53%     
==========================================
  Files          17       19       +2     
  Lines        2474     2604     +130     
  Branches      236      244       +8     
==========================================
+ Hits         2097     2221     +124     
- Misses        283      287       +4     
- Partials       94       96       +2     
Impacted Files Coverage Δ
slack/web/base_client.py 75.27% <66.66%> (-0.28%) ⬇️
slack/signature/verifier.py 88.57% <88.57%> (ø)
slack/signature/__init__.py 100.00% <100.00%> (ø)
slack/web/classes/messages.py 0.00% <0.00%> (ø)
slack/web/slack_response.py 98.00% <0.00%> (+0.04%) ⬆️
slack/web/classes/actions.py 98.94% <0.00%> (+0.07%) ⬆️
slack/rtm/client.py 83.33% <0.00%> (+0.07%) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58134fe...c352e88. Read the comment docs.

@seratch seratch merged commit 03586fe into slackapi:master May 15, 2020
@seratch seratch deleted the signature-verifier branch May 15, 2020 02:23
seratch added a commit to seratch/python-slack-sdk that referenced this pull request May 15, 2020
seratch added a commit to seratch/python-slack-sdk that referenced this pull request May 15, 2020
seratch added a commit to seratch/python-slack-sdk that referenced this pull request May 15, 2020
seratch added a commit that referenced this pull request May 15, 2020
Additional improvements for #686 and document updates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement M-T: A feature request for new functionality Version: 2x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant