Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional improvements for #686 and document updates #688

Merged
merged 1 commit into from
May 15, 2020

Conversation

seratch
Copy link
Member

@seratch seratch commented May 15, 2020

Summary

This pull request applies a minor improvement to #686 by having consideration for the "body" parameter as a bytes value. Also, it updates to the related document.

Requirements (place an x in each [ ])

@seratch seratch added Version: 2x enhancement M-T: A feature request for new functionality v2.6 in-progress labels May 15, 2020
@seratch seratch added this to the 2.6.0 milestone May 15, 2020
@codecov
Copy link

codecov bot commented May 15, 2020

Codecov Report

Merging #688 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #688      +/-   ##
==========================================
+ Coverage   85.29%   85.30%   +0.01%     
==========================================
  Files          19       19              
  Lines        2604     2606       +2     
  Branches      244      245       +1     
==========================================
+ Hits         2221     2223       +2     
  Misses        287      287              
  Partials       96       96              
Impacted Files Coverage Δ
slack/signature/verifier.py 89.18% <100.00%> (+0.61%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03586fe...22b98dc. Read the comment docs.

@seratch seratch merged commit e68f98f into slackapi:master May 15, 2020
@seratch seratch deleted the pr-686-addition branch May 15, 2020 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement M-T: A feature request for new functionality Version: 2x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant