This repository has been archived by the owner on Oct 30, 2018. It is now read-only.
Snapshot tests #168
Merged
Snapshot tests #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
April 18, 2015 16:16
… Deals with device, OS and density fragmentation too.
…ontent from the control.
| @end | ||
|
|
||
| @implementation MessageViewController | ||
|
|
||
| + (instancetype)stub |
There was a problem hiding this comment.
It will probably feel better if you have a category that exists in only your testing bundle that creates this stubbed version of the messageController
+ (instancetype)stubbedMessageViewController
{
}
There was a problem hiding this comment.
it can then set these Messages from below
There was a problem hiding this comment.
Yes, totally. I made that change while back, and forgot to remove it. Good catch!
|
Thanks for the feedback @orta! |
dzenbot
referenced
this pull request
in neonichu/SlackTextViewController
Apr 18, 2015
added 2 commits
April 18, 2015 16:49
…n loop, causing it to be nil sometimes.
dzenbot
pushed a commit
that referenced
this pull request
Apr 18, 2015
Adds basic snapshot tests to SlackTextViewController
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Liked described in to #134, we are adding snapshot tests to SLKTVC.
This PR includes:
It also includes minor tweaks to SLKTVC:
slk_clearText: