robot.emit 'error' for slack client errors #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like this has my changes from #229 in it too. I can rebase this PR with only the emit changes. |
technicalpickles
force-pushed
the
robot-emit-error-for-slack-client-errors
branch
from
90516db
to
6dd613b
Compare
|
I've cherry-picked the changes as I mentioned. |
This was referenced Sep 25, 2015
mjsz
added a commit
that referenced
this pull request
Oct 15, 2015
…-errors robot.emit 'error' for slack client errors
6 tasks
6 tasks
6 tasks
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm debugging an error I received overnight that crashed my hubot instance over at github#1 . Digging into it a bit more, I found that the adapter's error handler is exiting when the error happens.
This PR updates the adapter to not exit, and to use hubot's error handling instead of logging it (the error handling logs by default).