Switch to Compose-based markdown rendering solution #825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses a multiplatform compose markdown renderer for markdown rendering, offering a nicer UI for the whatsnew panel since Studio doesn't seem likely to ever support JCEF.
In the process of this, I also made a playground project where we can test compose UIs like this and project gen without needing to run a whole IDE flow to test, to make it easier to iterate. Now it's as easy as just running the
mainfunctions in those files.There are still some features missing from the markdown library like strikethrough, dividers, tables, etc, but the maintainer is responsive and I've been filing issues. This builds a best-effort bridge theme based off of Jewel. In the future we may also consider their in-development impl.