Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Background color for code snippet is subtly different #440

Closed
ketan opened this issue Feb 3, 2016 · 2 comments
Closed

Background color for code snippet is subtly different #440

ketan opened this issue Feb 3, 2016 · 2 comments

Comments

@ketan
Copy link

ketan commented Feb 3, 2016

See attachment — 

screen shot 2016-02-03 at 12 33 38 pm

There seem to be 2 colors there subtly different, but noticeable to the naked eye.

#292929 for .pre
#272822 for .highlight .w

This seems to have been caused by this change which causes the styles in the <style/> tag to override those specified in screen.scss.

The "fix" seems to be to to change the ordering of stylesheets in layout.erb to the following —

    <style>
      <%= Rouge::Themes::Base16::Monokai.render(:scope => '.highlight') %>
    </style>
    <%= stylesheet_link_tag :screen, media: :screen %>
    <%= stylesheet_link_tag :print, media: :print %>
@lord
Copy link
Member

lord commented Feb 3, 2016

Ooh, great catch! Thanks for documenting a fix too, much appreciated.

@lord lord closed this as completed in 28066ed Feb 3, 2016
@lord
Copy link
Member

lord commented Feb 3, 2016

Should be fixed now in master thanks for reporting!

sandro-pasquali referenced this issue in sandro-pasquali/slate Feb 11, 2016
tilod referenced this issue in isaac10-doc/isaac10_apidoc_v1 Feb 12, 2016
genaromadrid referenced this issue in Mifiel/api-doc Feb 16, 2016
* commit '28066ed281b84fd344216cb61009dadb7a125ca9': (45 commits)
  Fixes #440, version 1.3.2
  Add changelog for 1.3.1
  Fix broken word break styles
  Add version notes
  Add travis script
  Small readme improvement
  Remove Rake
  Make deploy script executable
  Add deploy script
  Fix travis bugs
  Remove docker
  Update Vagrant to work properly
  Remove last inline script
  Move jquery to be local
  Add comment about middleman hanging to config.rb
  Fix non-wrapping code in firefox
  Add code block warning
  Add parrot link
  It should have be it. It wasn't it. It was its.
  README copy-editing changes Applying the copy-editing changes noticed by Ira Brooker (@IOB1979) to the current master branch
  ...

# Conflicts:
#	.gitignore
#	.travis.yml
#	CHANGELOG.md
#	CONTRIBUTING.md
#	Gemfile
#	Gemfile.lock
#	README.md
#	Vagrantfile
#	source/images/logo.png
#	source/index.html.md
#	source/layouts/layout.erb
#	source/stylesheets/screen.css.scss
vogelito referenced this issue in bitsoex/slate Feb 19, 2016
lord added a commit that referenced this issue Mar 2, 2016
gmelika referenced this issue in gmelika/slate Jul 6, 2016
neilgrover referenced this issue in neilgrover/slate Mar 22, 2017
kyrylo referenced this issue in airbrake/slate Apr 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants