Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: add functionality for reseting to nullptr #2

Closed
dbkaplun opened this issue May 4, 2018 · 5 comments
Closed

Feature: add functionality for reseting to nullptr #2

dbkaplun opened this issue May 4, 2018 · 5 comments

Comments

@dbkaplun
Copy link
Contributor

dbkaplun commented May 4, 2018

Thanks for considering!
@torkleyy
Copy link
Member

torkleyy commented May 5, 2018

Hello @dbkaplun! Didn't think somebody would use this crate given that the last commit was 2015 :)

I'll look into it.

@torkleyy
Copy link
Member

torkleyy commented May 5, 2018

The method you're looking for is already implemented: Atom::take.

@torkleyy
Copy link
Member

torkleyy commented May 5, 2018

While looking through the source, I noticed there was a wrong assumption in the source which could technically cause undefined behavior.

@kvark I tried publishing 0.3.5 but I'm not an owner of this crate.

@kvark
Copy link
Member

kvark commented May 5, 2018

@torkleyy sorry about that! You've been invited now.

@torkleyy
Copy link
Member

torkleyy commented May 5, 2018

Thanks, fixed version is up now.

@dbkaplun dbkaplun closed this as completed May 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kvark @dbkaplun @torkleyy