Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

magic-move does not support max-height #1753

Closed
asm0dey opened this issue Jul 11, 2024 · 2 comments
Closed

magic-move does not support max-height #1753

asm0dey opened this issue Jul 11, 2024 · 2 comments

Comments

@asm0dey
Copy link

asm0dey commented Jul 11, 2024

Describe the bug

If the code lock is long with magic move I didn't find a way to set maxHeight to it. I tried both setting maxHeigth on child code block and on the magic-move itself, nothing seems to work

Minimal reproduction

Create a following code block

````md magic-move {maxHeight:'200px'}
```plain {1-4}
ID         TAG                                                    SIZE      COMMAND
cda5201e70 dumb:latest                                            0B        CMD ["/bin/sh" "-c" "/app/build/libs/spring-petclinic*.
74a0788411                                                        512.03MiB /bin/sh -c cd /app && ./gradlew build
7b82eb08ec                                                        67.41MiB  COPY dir:ef251bd1e17ac0afee8fa279c87fa2e7a561e3ea2550a2
e4bcf83d29 bellsoft/liberica-runtime-container:jdk-21.0.3_10-musl 98.32MiB  |15 BUNDLE_TYPE=jdk CDS=no DESCRIPTION=Alpaquita Stream
<missing>                                                         0B        ENV JAVA_HOME="/usr/lib/jvm/liberica${JAVA_RELEASE}-lit
<missing>                                                         0B        ENV LANG=en_US.UTF-8 LANGUAGE=en_US:en
<missing>                                                         0B        LABEL org.opencontainers.image.description="$DESCRIPTIO
<missing>                                                         0B        LABEL org.opencontainers.image.authors="$MAINTAINER"
<missing>                                                         0B        LABEL maintainer="$MAINTAINER"
<missing>                                                         0B        ARG BUNDLE_TYPE CDS DESCRIPTION JAVA_RELEASE MAINTAINER
<missing>                                                         0B        ARG BUNDLE_TYPE CDS JAVA_RELEASE MAINTAINER REMOVE_APK_
<missing>                                                         0B        ARG BUNDLE_TYPE CDS JAVA_RELEASE REMOVE_APK_TOOLS
<missing>                                                         0B        ARG BUNDLE_TYPE CDS JAVA_RELEASE
<missing>                                                         0B        ARG BUNDLE_TYPE JAVA_RELEASE
<missing>                                                         0B        ARG JAVA_RELEASE
<missing>                                                         7.49MiB   CMD ["/bin/sh"]
<missing>                                                         0B        |9 APK_REPOS= DESCRIPTION=Alpaquita Stream Musl LIBC=mu
<missing>                                                         0B        ADD file:a4d77f495452c76cfe3204f86342884fffc18fc02c51bd
<missing>                                                         0B        LABEL org.opencontainers.image.description="$DESCRIPTIO
<missing>                                                         0B        LABEL org.opencontainers.image.authors="$MAINTAINER"
<missing>                                                         0B        LABEL maintainer="$MAINTAINER"
<missing>                                                         0B        ARG APK_REPOS DESCRIPTION LIBC LOCALES MAINTAINER MINIR
<missing>                                                         0B        ARG APK_REPOS LIBC LOCALES MAINTAINER MINIROOTFS
<missing>                                                         0B        ARG APK_REPOS LIBC LOCALES MINIROOTFS
<missing>                                                         0B        ARG APK_REPOS LIBC MINIROOTFS
<missing>                                                         0B        ARG LIBC MINIROOTFS
<missing>                                                         0B        ARG MINIROOTFS
```
```plain {1-3}
ID         TAG                                                    SIZE     COMMAND
cefb30e21d smarter:latest                                         0B       CMD ["/bin/sh" "-c" "java -jar /app/app.jar"]
46d7594000                                                        58.80MiB COPY file:8d96bee95ae5ce431ee4bc4de6cf0725f36464e95bc0d
e4bcf83d29 bellsoft/liberica-runtime-container:jdk-21.0.3_10-musl 98.32MiB |15 BUNDLE_TYPE=jdk CDS=no DESCRIPTION=Alpaquita Stream
<missing>                                                         0B       ENV JAVA_HOME="/usr/lib/jvm/liberica${JAVA_RELEASE}-lit
<missing>                                                         0B       ENV LANG=en_US.UTF-8 LANGUAGE=en_US:en
<missing>                                                         0B       LABEL org.opencontainers.image.description="$DESCRIPTIO
<missing>                                                         0B       LABEL org.opencontainers.image.authors="$MAINTAINER"
<missing>                                                         0B       LABEL maintainer="$MAINTAINER"
<missing>                                                         0B       ARG BUNDLE_TYPE CDS DESCRIPTION JAVA_RELEASE MAINTAINER
<missing>                                                         0B       ARG BUNDLE_TYPE CDS JAVA_RELEASE MAINTAINER REMOVE_APK_
<missing>                                                         0B       ARG BUNDLE_TYPE CDS JAVA_RELEASE REMOVE_APK_TOOLS
<missing>                                                         0B       ARG BUNDLE_TYPE CDS JAVA_RELEASE
<missing>                                                         0B       ARG BUNDLE_TYPE JAVA_RELEASE
<missing>                                                         0B       ARG JAVA_RELEASE
<missing>                                                         7.49MiB  CMD ["/bin/sh"]
<missing>                                                         0B       |9 APK_REPOS= DESCRIPTION=Alpaquita Stream Musl LIBC=mu
<missing>                                                         0B       ADD file:a4d77f495452c76cfe3204f86342884fffc18fc02c51bd
<missing>                                                         0B       LABEL org.opencontainers.image.description="$DESCRIPTIO
<missing>                                                         0B       LABEL org.opencontainers.image.authors="$MAINTAINER"
<missing>                                                         0B       LABEL maintainer="$MAINTAINER"
<missing>                                                         0B       ARG APK_REPOS DESCRIPTION LIBC LOCALES MAINTAINER MINIR
<missing>                                                         0B       ARG APK_REPOS LIBC LOCALES MAINTAINER MINIROOTFS
<missing>                                                         0B       ARG APK_REPOS LIBC LOCALES MINIROOTFS
<missing>                                                         0B       ARG APK_REPOS LIBC MINIROOTFS
<missing>                                                         0B       ARG LIBC MINIROOTFS
<missing>                                                         0B       ARG MINIROOTFS
```
````
  1. render the slide
  2. see that the code overflows

You can use https://sli.dev/new to create a new project to reproduce the issue.

Environment

  • Slidev version: ^0.49.16
  • Browser: Chrome
  • OS: Linux
@KermanX
Copy link
Member

KermanX commented Jul 12, 2024

See #1531

@KermanX KermanX closed this as completed Jul 12, 2024
@asm0dey
Copy link
Author

asm0dey commented Jul 12, 2024

Thanks! Would be cool to see it in the docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants