Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use pnpm catalog #1750

Closed
wants to merge 5 commits into from
Closed

Conversation

btea
Copy link
Contributor

@btea btea commented Jul 11, 2024

Copy link

netlify bot commented Jul 11, 2024

Deploy Preview for slidev ready!

Name Link
🔨 Latest commit 341d359
🔍 Latest deploy log https://app.netlify.com/sites/slidev/deploys/66beb0fd1ccc5d0009e9c3f4
😎 Deploy Preview https://deploy-preview-1750--slidev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@KermanX
Copy link
Member

KermanX commented Jul 12, 2024

Does https://github.com/antfu-collective/taze support PNPM catalog?

@btea
Copy link
Contributor Author

btea commented Jul 12, 2024

I checked the code and it seems that it is not supported at present.

@btea
Copy link
Contributor Author

btea commented Jul 13, 2024

@KermanX I created a PR. antfu-collective/taze#123

@antfu
Copy link
Member

antfu commented Aug 15, 2024

Would you like to help solving the conflicts, or redo the PR? Thanks

@btea btea marked this pull request as draft August 16, 2024 01:56
@KermanX
Copy link
Member

KermanX commented Aug 16, 2024

The problem is that our smoke test CI needs to pack the packages. Not sure why pnpm pack doesn't resolve catelog: protocol.

@btea
Copy link
Contributor Author

btea commented Aug 16, 2024

There were a lot of conflicts, so I created a new PR #1820.

@btea btea closed this Aug 16, 2024
@btea
Copy link
Contributor Author

btea commented Aug 16, 2024

The problem is that our smoke test CI needs to pack the packages. Not sure why pnpm pack doesn't resolve catelog: protocol.

According to the error message, it seems that npm was used to install dependencies, but npm does not support the catalog protocol.

@btea btea deleted the chore/use-pnpm-catalog branch August 16, 2024 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants