Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UA shouldn't be required to invoke Soft Update on every navigation #715

Closed
mfalken opened this issue Jun 23, 2015 · 5 comments
Closed

UA shouldn't be required to invoke Soft Update on every navigation #715

mfalken opened this issue Jun 23, 2015 · 5 comments

Comments

@mfalken
Copy link
Member

mfalken commented Jun 23, 2015

I'm not sure the UA should be required to run Soft Update on each navigation. The UA may want to coalesce the updates, so a barrage of reload or opening new tabs etc only results in one Soft Update in some time period. In Chrome's current implementation, if two update requests are triggered within one second of each other, only one update occurs. In future implementations, we may make this more like 10 seconds or something, to be easier on battery/network.

@jungkees
Copy link
Collaborator

I think it's a fair point considering mobile resource usage. But IIRC, one of the points @jakearchibald concerned about was doing it less often seems to make devs hard. Is it still true? or devtools might resolve the concern?

@mfalken
Copy link
Member Author

mfalken commented Jun 24, 2015

Yes I expect DevTools would resolve that concern. Update on Navigate isn't even that useful for development since you have to disable the HTTP cache and also remember to close controllees or use skipWaiting.

@jakearchibald
Copy link
Contributor

Update on Navigate isn't even that useful for development since you have to disable the HTTP cache and also remember to close controllees or use skipWaiting

I've found update on navigate really useful during development for testing update handling. I tend to have must-revalidate on my SW scripts so HTTP caching isn't a problem.

But if we're talking one second as a coalescing period, that seems fair if it's worth it.

Curious to know how Mozilla feels about this @nikhilm @wanderview.

@wanderview
Copy link
Member

To be honest, we haven't gotten to any kind of optimization work. So we haven't really seen this yet. Some amount of coalescing seems reasonable to me, though.

@jakearchibald jakearchibald added this to the Version 1 milestone Oct 28, 2015
@jungkees
Copy link
Collaborator

jungkees commented Nov 4, 2015

We had a resolution for this issue in the f2f during TPAC: #759 (comment).

In sum, the Update request is just being dropped if there's an ongoing Update execution already in the queue for this registration.

Closing.

@jungkees jungkees closed this as completed Nov 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants