Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seperate SQL statements into their own .sql files #32

Closed
TheBusyBiscuit opened this issue Oct 9, 2020 · 2 comments
Closed

Seperate SQL statements into their own .sql files #32

TheBusyBiscuit opened this issue Oct 9, 2020 · 2 comments
Assignees
Labels
Hacktoberfest This Issue or Pull Request is part of the Hacktoberfest!

Comments

@TheBusyBiscuit
Copy link
Member

📍 Description (REQUIRED)

Right now the classes DBUpdaterTask.java and LocationManager.java contain SQL statements in them as strings.

I would like to seperate these into their own dedicated .sql files and load them at runtime, this way it will be easier for us to edit these queries later down the line.

@TheBusyBiscuit TheBusyBiscuit added the Hacktoberfest This Issue or Pull Request is part of the Hacktoberfest! label Oct 9, 2020
@idodin
Copy link

idodin commented Oct 9, 2020

Hi - I'd be interested in helping out with this. Is there an ideal directory structure you'd like to store the .sql files in?

@TheBusyBiscuit
Copy link
Member Author

Well, as the files are required to be available at runtime, they should go into the src/main/resources directory, so my suggestion would be something like src/main/resources/sql.
This new directory might also be needed to be added as a resource entry in the pom.xml then.

But yeah that's awesome, thanks ❤️
I went ahead and assigned you to this issue, let me know if you have any more questions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hacktoberfest This Issue or Pull Request is part of the Hacktoberfest!
Projects
None yet
Development

No branches or pull requests

2 participants